build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32076 )
Change subject: mb/protectli/vault: Add FW2B and FW4B Braswell based boards support
......................................................................
Patch Set 18:
(2 comments)
https://review.coreboot.org/c/coreboot/+/32076/18/src/mainboard/protectli/va...
File src/mainboard/protectli/vault_bsw/irqroute.h:
https://review.coreboot.org/c/coreboot/+/32076/18/src/mainboard/protectli/va...
PS18, Line 8: #define PCI_DEV_PIRQ_ROUTES \
Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/32076/18/src/mainboard/protectli/va...
PS18, Line 19: #define PIRQ_PIC_ROUTES \
Macros with complex values should be enclosed in parentheses
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32076
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I553fd3a89299314a855f055014ca7645100e12e7
Gerrit-Change-Number: 32076
Gerrit-PatchSet: 18
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 09 Mar 2020 12:17:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment