Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34582 )
Change subject: soc/intel/common/block/uart: Update the UART PCI device reference ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34582/1/src/soc/intel/cannonlake/ua... File src/soc/intel/cannonlake/uart.c:
https://review.coreboot.org/c/coreboot/+/34582/1/src/soc/intel/cannonlake/ua... PS1, Line 53: struct device *soc_uart_console_to_device(int uart_console)
Plus, I don't see the functions manipulating the value returned by soc_uart_console_to_device and […]
Ok I have the common UART functions to return and accept const data. For ACPI common driver , I had to type cast , if I did not , find_resource function also needed change and corresponding calls needed to be updated(>240 references).
https://review.coreboot.org/c/coreboot/+/34582/1/src/soc/intel/common/block/... File src/soc/intel/common/block/uart/uart.c:
https://review.coreboot.org/c/coreboot/+/34582/1/src/soc/intel/common/block/... PS1, Line 112: uart_get_device
Missing NULL check.
Done
https://review.coreboot.org/c/coreboot/+/34582/1/src/soc/intel/common/block/... PS1, Line 146: uart_get_device
Missing NULL check.
Done