Attention is currently required from: Nico Huber, Angel Pons, Utkarsh Verma.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74128 )
Change subject: arch/x86/smbios: Avoid buffer overflows
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74128/comment/ea1bde66_0cb67e4d
PS3, Line 9: The format specifiers for numbers in snprintf() calls are updated to be
Possible unwrapped commit description (prefer a maximum 72 chars per line) […]
The checkpatch comments are unfortunately added to the wrong line and refer to the line below, which is 76 characters long.
https://review.coreboot.org/c/coreboot/+/74128/comment/b294a6fd_45cd9ac5
PS3, Line 21:
The blank line could be removed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74128
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibbf93fd113791b6faa1e5128da8e692f7f00ac73
Gerrit-Change-Number: 74128
Gerrit-PatchSet: 3
Gerrit-Owner: Utkarsh Verma
utkarsh@bitbanged.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Utkarsh Verma
utkarsh@bitbanged.com
Gerrit-Comment-Date: Sun, 02 Apr 2023 14:00:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Utkarsh Verma
utkarsh@bitbanged.com
Gerrit-MessageType: comment