Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38213 )
Change subject: nb/intel/{i945,x4x,pineview}: Remove wrapper spd_read_byte()
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38213/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38213/1//COMMIT_MSG@7
PS1, Line 7: nb/intel/i945,x4x,pineview: Remove wrapper spd_read_byte()
I'd put the northbridge names between curly brackets, as it helps others' internal parsers: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38213
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic9554ad2813ee70d0da16857d534aab5e17d808f
Gerrit-Change-Number: 38213
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 08 Jan 2020 18:26:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment