Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31709 )
Change subject: mainboard: Enable PRESERVE flag in all vboot/chromeos FMD files
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/31709/3/src/mainboard/google/cheza/chromeos....
File src/mainboard/google/cheza/chromeos.fmd:
https://review.coreboot.org/#/c/31709/3/src/mainboard/google/cheza/chromeos....
PS3, Line 38: RW_SHARED 4K {
Should we preserve these too? Right now they usually just contain netboot info which should rarely matter for updates, but it doesn't seem impossible that we may want to reuse them for something else in a later update.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31709
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6664ae3d955001ed14374e2788d400ba5fb9b7f8
Gerrit-Change-Number: 31709
Gerrit-PatchSet: 3
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: York Yang
york.yang@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 04 Mar 2019 21:03:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment