
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36354 ) Change subject: soc/intel/skylake: use cpu_lt_lock_memory in cpu_lock_sgx_memory ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/c/coreboot/+/36354/1/src/soc/intel/skylake/cpu.c File src/soc/intel/skylake/cpu.c: https://review.coreboot.org/c/coreboot/+/36354/1/src/soc/intel/skylake/cpu.c... PS1, Line 579: void cpu_lock_sgx_memory(void)
Yep, because when SGX is enabled the lock *MUST* happen before SGX init; every platform after skl/kb […] ... so cpu_lock_sgx_memory() must be empty for those platforms
-- To view, visit https://review.coreboot.org/c/coreboot/+/36354 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iefec0e61c7482a70af60dabc0bec3bf712d8b48a Gerrit-Change-Number: 36354 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Wed, 30 Oct 2019 22:55:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner Comment-In-Reply-To: Nico Huber <nico.h@gmx.de> Gerrit-MessageType: comment