Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43133 )
Change subject: soc/intel/baytrail: Add native refcode replacement ......................................................................
Patch Set 12: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/43133/12/src/soc/intel/baytrail/ref... File src/soc/intel/baytrail/refcode_native.c:
https://review.coreboot.org/c/coreboot/+/43133/12/src/soc/intel/baytrail/ref... PS12, Line 15: static void mmio_or32(u32 addr, u32 val) : { : u32 tmp; : : tmp = read32((char *) addr); : write32((char *) addr, tmp | val); : } : : static void mmio_and32(u32 addr, u32 val) : { : u32 tmp; : : tmp = read32((char *) addr); : write32((char *) addr, tmp & val); : } : : static void mmio_andor32(u32 addr, u32 val1, u32 val2) : { : u32 tmp; : : tmp = read32((char *) addr); : write32((char *) addr, (tmp & val1) | val2); : } please use clrsetbitxx, setbitxx and clrbitxx from include/device/mmio.h