Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38420 )
Change subject: commonlib: Add commonlib/bsd
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38420/3/src/commonlib/bsd/include/c...
File src/commonlib/bsd/include/commonlib/bsd/fmap_serialized.h:
https://review.coreboot.org/c/coreboot/+/38420/3/src/commonlib/bsd/include/c...
PS3, Line 27: __packed
Shouldn't we #including commonlib/compiler. […]
Oops, true. But I can't have #includes from commonlib/bsd back into commonlib. Let me pull the rest of compiler.h into commonlib/bsd as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38420
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I316cea70930f131e8e93d4218542ddb5ae4b63a2
Gerrit-Change-Number: 38420
Gerrit-PatchSet: 3
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Thu, 23 Jan 2020 18:33:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment