Attention is currently required from: Shreesh Chhabbi, Ravishankar Sarawadi, Duncan Laurie, Alex Levin, Sukumar Ghorai, Raj Astekar, Patrick Rudolph.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49766 )
Change subject: soc/intel/tgl: Disable S0i3.2 & S0i3.3 substates
......................................................................
Patch Set 22:
(2 comments)
Patchset:
PS22:
There are some pending comments on the previous patchset. Are you planning to resolve those? I can then go ahead and review once you are done addressing the prior comments.
File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/49766/comment/1d7a96fa_6a2e86bf
PS22, Line 61: if ((cpu_id != CPUID_TIGERLAKE_A0) || (cpu_id != CPUID_TIGERLAKE_B0)) {
braces {} are not necessary for single statement blocks
Can you please address this?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49766
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f2ac8b72d0c9b05bc02c092188d0c742cc83af9
Gerrit-Change-Number: 49766
Gerrit-PatchSet: 22
Gerrit-Owner: Shreesh Chhabbi
shreesh.chhabbi@intel.com
Gerrit-Reviewer: Alex Levin
levinale@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shreesh Chhabbi
shreesh.chhabbi@intel.corp-partner.google.com
Gerrit-Reviewer: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Shreesh Chhabbi
shreesh.chhabbi@intel.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Duncan Laurie
dlaurie@chromium.org
Gerrit-Attention: Alex Levin
levinale@google.com
Gerrit-Attention: Duncan Laurie
dlaurie@gmail.com
Gerrit-Attention: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Attention: Raj Astekar
raj.astekar@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Shreesh Chhabbi
shreesh.chhabbi@intel.corp-partner.google.com
Gerrit-Comment-Date: Fri, 05 Feb 2021 20:12:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment