18 Jun
2019
18 Jun
'19
11:57 a.m.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33487 )
Change subject: acpi: Add SPMI table ......................................................................
Patch Set 6:
(1 comment)
Patch Set 3:
(1 comment)
Mention SPMI spec link https://www.intel.com/content/dam/www/public/us/en/documents/product-briefs/... will be better.
Done.
https://review.coreboot.org/#/c/33487/3/src/arch/x86/acpi.c File src/arch/x86/acpi.c:
https://review.coreboot.org/#/c/33487/3/src/arch/x86/acpi.c@812 PS3, Line 812: spmi->interrupt_type |= 1
Instead of |=, just use "=" directly? Instead of using value 1 and 2 directly, may be replace with 1 […]
added defines for interrupts and PCI device flag
--
To view, visit https://review.coreboot.org/c/coreboot/+/33487
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idff5134ce4c124f7e76acb0080da404b0c0dfffe
Gerrit-Change-Number: 33487
Gerrit-PatchSet: 6
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Lijian Zhao lijian.zhao@intel.com
Gerrit-CC: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Tue, 18 Jun 2019 09:57:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lijian Zhao lijian.zhao@intel.com
Gerrit-MessageType: comment