Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35726 )
Change subject: drivers/aspeed/common: Add support for high resolution framebuffer ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35726/1/src/drivers/aspeed/common/a... File src/drivers/aspeed/common/ast_drv.h:
https://review.coreboot.org/c/coreboot/+/35726/1/src/drivers/aspeed/common/a... PS1, Line 47: AST2500,
Why has this been added here?
It's used by ast_mode.c.
https://review.coreboot.org/c/coreboot/+/35726/1/src/drivers/aspeed/common/a... File src/drivers/aspeed/common/ast_i2c.c:
https://review.coreboot.org/c/coreboot/+/35726/1/src/drivers/aspeed/common/a... PS1, Line 128: i2c_recover_bus(bus);
Why are you doing this here? Do you have reason to believe the bus would be wedged here? I'd keep th […]
Both sda and scl have been pulled low by the ast post code. The code brings the bus back into a known state.
https://review.coreboot.org/c/coreboot/+/35726/1/src/drivers/aspeed/common/a... PS1, Line 133: ast = ast_priv;
I don't want to look too closely into the platform code here, but... […]
Both functions are only called once. I'll remove one of them.