27 Jun
2019
27 Jun
'19
5:25 a.m.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33819 )
Change subject: mb/google/hatch: Add INVERT to all IOAPIC pads ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/33819/1/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/33819/1/src/mainboard/google/hatch/variants/... PS1, Line 217: NONE
What about this?
I see that you are doing this in follow-up CL.
--
To view, visit https://review.coreboot.org/c/coreboot/+/33819
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b125996338b6f16e03b7ca184f6337c696a5f64
Gerrit-Change-Number: 33819
Gerrit-PatchSet: 1
Gerrit-Owner: Shelley Chen shchen@google.com
Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Philip Chen philipchen@chromium.org
Gerrit-CC: Philip Chen philipchen@google.com
Gerrit-Comment-Date: Thu, 27 Jun 2019 02:25:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment