EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35945 )
Change subject: mb/google/drallion: Add new SPD file for drallion
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35945/5/src/mainboard/google/dralli...
File src/mainboard/google/drallion/spd/micron_dimm_MT40A1G16KD-062EE.spd.hex:
https://review.coreboot.org/c/coreboot/+/35945/5/src/mainboard/google/dralli...
PS5, Line 21: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
Is it needed for memory down? The SPD data I received has all 0s for part number.
In some project part number is reported by CBI command. But we need them, I'll check, please hold on.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35945
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d1ae9269ff3129845a7f53dbacbab6e1b66b6d5
Gerrit-Change-Number: 35945
Gerrit-PatchSet: 5
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 11 Oct 2019 04:25:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Comment-In-Reply-To: Bora Guvendik
bora.guvendik@intel.com
Gerrit-MessageType: comment