John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42187 )
Change subject: mb/google/dedede/variants/waddledoo: Adjust I2Cs CLK to meet spec
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42187/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42187/1//COMMIT_MSG@7
PS1, Line 7: spec
I2C clock under 400 kHZ. […]
Ack
https://review.coreboot.org/c/coreboot/+/42187/1//COMMIT_MSG@12
PS1, Line 12: Audio CLK: 350.9 KHz
The values are over 400 kHZ before.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42187
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec02a751f1effdbefbb2969db2fd57f27ecdd033
Gerrit-Change-Number: 42187
Gerrit-PatchSet: 1
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 09 Jun 2020 01:52:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: John Su
john_su@compal.corp-partner.google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment