Attention is currently required from: Ravishankar Sarawadi, Kapil Porwal, Angel Pons, Arthur Heymans, Lean Sheng Tan, Werner Zeh, Raj Astekar.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70751 )
Change subject: soc/intel/common: Fix cpu index calculation
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
I think it would be best to rework this code and put the information whether it is a big or small co […]
Yes, it is worth associating the core type along with apic id as part of struct device as this can be useful for cpu index based on APIC IDs as well as preparing the MADT table where in big cores have to be placed first and then small cores.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70751
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69e5e6231dd18b43d439340aaed50eb9edeca3b7
Gerrit-Change-Number: 70751
Gerrit-PatchSet: 4
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Raj Astekar
raj.astekar@intel.com
Gerrit-Comment-Date: Sun, 18 Dec 2022 07:35:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment