Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36706 )
Change subject: sb/lynxpoint: Use macros instead of hard-coded IDs ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36706/3/src/include/device/pci_ids.... File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/36706/3/src/include/device/pci_ids.... PS3, Line 2700: #define PCI_DEVICE_ID_INTEL_LPT_LP_LPC_VALUE 0x9c47
We don't need it, but I think this is more consistent since every other group is titled with somethi […]
Searching for LPC?!? It's inconsistent with the line right below btw.
https://review.coreboot.org/c/coreboot/+/36706/3/src/include/device/pci_ids.... PS3, Line 3005: #define PCI_DEVICE_ID_INTEL_SPT_U_Y_PREMIUM_SATA 0x9d07
What do you mean? I moved these two down because the IDs are higher than the LPT ones.
You didn't move them, you just added lines above them _and_ fixed whitespace. The latter usually belongs into a separate commit. It's no big deal, just bad practice.