[coreboot-gerrit] [S] Change in coreboot[master]: drivers/fsp2: Don't die if the FSP signature doesn't match

[Martin L Roth (Code Review)]

Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69412 )

Change subject: drivers/fsp2: Don't die if the FSP signature doesn't match
......................................................................

drivers/fsp2: Don't die if the FSP signature doesn't match

If the FSP signature doesn't match, there's going to be something else
that kills the system, or not.  Either way, killing the system in
coreboot isn't needed.  We should absolutely print an error message, but
let the FSP take care of halting the system or better still, returning to
let coreboot print a message and halt at that point.

Signed-off-by: Martin Roth 
Change-Id: I12aca7cad3298ac36b1fed09efaa190c958cf126
---
M src/drivers/intel/fsp2_0/util.c
1 file changed, 17 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/69412/1

diff --git a/src/drivers/intel/fsp2_0/util.c b/src/drivers/intel/fsp2_0/util.c
index 1dedb65..1f8e12f 100644
--- a/src/drivers/intel/fsp2_0/util.c
+++ b/src/drivers/intel/fsp2_0/util.c
@@ -182,7 +182,7 @@
    if (upd_signature != expected_signature) {
    	/* The UPD signatures are non-zero-terminated ASCII stored as a little endian
    	   uint64_t, so this needs some casts. */
-		die_with_post_code(POST_INVALID_VENDOR_BINARY,
+		printk(BIOS_EMERG,
    		"Invalid UPD signature! FSP provided "%8s", expected was "%8s".\n",
    		(char *)&upd_signature,
    		(char *)&expected_signature);