build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69804 )
Change subject: src/device: Remove unnecessary space after casts ......................................................................
Patch Set 1:
(49 comments)
File src/device/oprom/x86emu/ops.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/0fc6c032_e3e97720 PS1, Line 1592: imm = (s8)fetch_byte_imm(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/5b2a2960_e64c3672 PS1, Line 1592: imm = (s8)fetch_byte_imm(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/5abc7363_5ffce2b8 PS1, Line 1602: imm = (s8)fetch_byte_imm(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/2aede2d8_0be29751 PS1, Line 1602: imm = (s8)fetch_byte_imm(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/f5ef4dfe_d224b179 PS1, Line 1614: imm = (s8)fetch_byte_imm(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/2a39e80a_a44b38bc PS1, Line 1614: imm = (s8)fetch_byte_imm(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/4f419ab9_a07addcb PS1, Line 1622: imm = (s8)fetch_byte_imm(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/f3324d3e_afae1dea PS1, Line 1622: imm = (s8)fetch_byte_imm(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/1ff1c454_71ea2130 PS1, Line 3580: tmp = (u16)mem_access_word(3 * 4 + 2); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/cee3fdb1_5c80804a PS1, Line 4090: ip = (s8)fetch_byte_imm(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/2461a94e_ff342df7 PS1, Line 4091: ip += (s16)M.x86.R_IP; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/2e1f1928_1659cf17 PS1, Line 4114: ip = (s8)fetch_byte_imm(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/048cfef3_04888b60 PS1, Line 4115: ip += (s16)M.x86.R_IP; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/97ee2a7f_b576eabe PS1, Line 4138: ip = (s8)fetch_byte_imm(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/fdd672e6_ef7a999e PS1, Line 4139: ip += (s16)M.x86.R_IP; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/82469b1d_ed1ff07a PS1, Line 4276: ip32 = (s32)fetch_long_imm(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/4c2d9dee_48e00e8f PS1, Line 4276: ip32 = (s32)fetch_long_imm(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/2e1c59df_5dd14197 PS1, Line 4277: ip32 += (s16)M.x86.R_IP; /* CHECK SIGN */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/be8f2819_7b76eadb PS1, Line 4277: ip32 += (s16)M.x86.R_IP; /* CHECK SIGN */ please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/cd25a782_43d38ef8 PS1, Line 4281: ip16 = (s16)fetch_word_imm(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/ac0e3de6_08dc0c64 PS1, Line 4281: ip16 = (s16)fetch_word_imm(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/d189007a_f4549617 PS1, Line 4282: ip16 += (s16)M.x86.R_IP; /* CHECK SIGN */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/786b4350_ff92cca1 PS1, Line 4282: ip16 += (s16)M.x86.R_IP; /* CHECK SIGN */ please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/ca73c3ee_0d97b520 PS1, Line 5195: M.x86.R_IP = (u16)(*destreg); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/32a59a3f_4405eb8f PS1, Line 5195: M.x86.R_IP = (u16)(*destreg); please, no spaces at the start of a line
File src/device/oprom/x86emu/ops2.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/527b7d6c_4dded6d0 PS1, Line 293: target = (s16)fetch_word_imm(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/96afe14f_a218fd86 PS1, Line 294: target += (s16)M.x86.R_IP; please, no spaces at the start of a line
File src/device/oprom/x86emu/prim_ops.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/58c2a1aa_0844fe5f PS1, Line 1205: } else { suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/26940eed_9b95f8e3 PS1, Line 1206: res = (u8)d; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/9e2ec71a_2fe89799 PS1, Line 1206: res = (u8)d; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/cc707c7f_aa53ae57 PS1, Line 1245: } else { suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/c2135fe0_7ca503fd PS1, Line 1246: res = (u16)d; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/3c8befdf_cbcfb380 PS1, Line 1246: res = (u16)d; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/6afdbe79_e993a143 PS1, Line 1318: } else { suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/71d0d27f_18318ef3 PS1, Line 1319: res = (u8)d; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/33b8e0d2_4a778891 PS1, Line 1319: res = (u8)d; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/6896b5b6_9013a70c PS1, Line 2063: M.x86.R_AL = (s8)div; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/8d77a0ce_29eec4d5 PS1, Line 2064: M.x86.R_AH = (s8)mod; please, no spaces at the start of a line
File src/device/oprom/yabel/compat/functions.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/431054f4_08f2a7d8 PS1, Line 49: u8* vmem = (u8 *)CONFIG_YABEL_VIRTMEM_LOCATION; "foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/f45d5895_7e8d9392 PS1, Line 51: u8* vmem = (u8 *)(16*1024*1024); /* default to 16MB */ "foo* bar" should be "foo *bar"
File src/device/oprom/yabel/compat/of.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/ff6478a1_b18145f1 PS1, Line 37: #define p32cast (int)(unsigned long) (void *) Macros with complex values should be enclosed in parentheses
File src/device/oprom/yabel/device.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/3eb5ebcb_8f005437 PS1, Line 154: *((u32*)addr) = cpu_to_le32(val); "(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/203707e0_676c87d3 PS1, Line 176: *((u16*)addr) = cpu_to_le16(val); "(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/ffc3f473_a1e76622 PS1, Line 187: val = cpu_to_le16(*((u16*)addr)); "(foo*)" should be "(foo *)"
File src/device/oprom/yabel/interrupt.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/09851326_2d817a39 PS1, Line 235: char_code = (u8)* keycode & 0xff; space prohibited after that '*' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/a32376a0_e83db464 PS1, Line 250: *keycode = (u64)((((u16) scan_code) << 8) | char_code); Possible repeated word: 'keycode'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/edc9b076_3d6987a7 PS1, Line 276: M.x86.R_AX = (u16)* keycode; space prohibited after that '*' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/4b6f4282_0fb09cbb PS1, Line 291: M.x86.R_AX = (u16)* keycode; space prohibited after that '*' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164029): https://review.coreboot.org/c/coreboot/+/69804/comment/1bef0cdd_d9ea159d PS1, Line 321: M.x86.R_AX = (u16)* keycode; space prohibited after that '*' (ctx:VxW)