Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33919 )
Change subject: mb/asus/am1i-a/buildOpts.c: set a board type to AMD_PLATFORM_DESKTOP
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33919/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/33919/6//COMMIT_MSG@9
PS6, Line 9: Original AMD_PLATFORM_MOBILE is incorrect because this board is a desktop one.
There is AMD vendorcode which is active only if AMD_PLATFORM_MOBILE is enabled: […]
Is there a noticeable improvement, though? Sorry if I wasn't clear enough before.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33919
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I02adedffe8624c38e7b93fadd0449ddf094388fd
Gerrit-Change-Number: 33919
Gerrit-PatchSet: 7
Gerrit-Owner: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 11 Apr 2020 10:10:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Mike Banon
mikebdp2@gmail.com
Gerrit-MessageType: comment