Attention is currently required from: Balaji Manigandan, Deepti Deshatty, Eric Lai, Felix Singer, Kapil Porwal, Krishna P Bhat D, Paul Menzel.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79211?usp=email )
Change subject: mb/intel/mtlrvp: define a new config for Chrome EC ......................................................................
Patch Set 9:
(6 comments)
File src/mainboard/intel/mtlrvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/79211/comment/0f6594a0_dbf835b3 : PS9, Line 29: select BOARD_EXT_EC_SPECIFIC_OPTIONS select BOARD_MTLRVP_EC_GOOGLE_CHROMEEC_COMMON
https://review.coreboot.org/c/coreboot/+/79211/comment/d46394da_5c804fda : PS9, Line 33: select SOC_INTEL_METEORLAKE_PRE_PRODUCTION_SILICON select BOARD_MTLRVP_EC_GOOGLE_CHROMEEC_COMMON
https://review.coreboot.org/c/coreboot/+/79211/comment/d901e170_a6dad16f : PS9, Line 38: select SOC_INTEL_METEORLAKE_PRE_PRODUCTION_SILICON select BOARD_MTLRVP_EC_GOOGLE_CHROMEEC_COMMON
https://review.coreboot.org/c/coreboot/+/79211/comment/ab1cdddb_2485260c : PS9, Line 47: BOARD_MTLRVP_EC_GOOGLE_CHROMEEC_COMMON why not below platform selects this config directly
BOARD_INTEL_MTLRVP_P_EXT_EC BOARD_INTEL_MTLRVP4ES_P_EXT_EC BOARD_INTEL_MTLRVP_P_MCHP
https://review.coreboot.org/c/coreboot/+/79211/comment/fa480619_22dbaaa4 : PS9, Line 114: MTL_CHROME_EC_SHARED_SPI please move this change into a specific CL where you are adding the support for shared SPI
https://review.coreboot.org/c/coreboot/+/79211/comment/646d26b6_54f4bbf8 : PS9, Line 121: select BOARD_MTLRVP_EC_GOOGLE_CHROMEEC_COMMON you don't need this selection. follow my comment above