Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36418 )
Change subject: [NOT FOR MERGE]: Demo adding near_reset_vector symbol
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36418/1/src/cpu/x86/16bit/reset16.l...
File src/cpu/x86/16bit/reset16.ld:
https://review.coreboot.org/c/coreboot/+/36418/1/src/cpu/x86/16bit/reset16.l...
PS1, Line 21: _NEAR_RESET_VECTOR
Well it can't be any higher. Seems to waste some 3 KiB though, unless we pushed other asm source into that section too (walkcbfs.S microcode_asm.S cache_as_ram.S).
with C_ENVIRONMENT_BOOTBLOCK a lot (still relatively little in comparison with todays flash sizes) of waste is expected in the bootblock as the region is bottom aligned. Might as well make use of it?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36418
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e7888c778e1d1cc426e4160543f4a4662ebf834
Gerrit-Change-Number: 36418
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Tue, 29 Oct 2019 10:21:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment