Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47893 )
Change subject: mb/ocp/deltalake: Update SMBIOS type 8 information ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/47893/1/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/ramstage.c:
https://review.coreboot.org/c/coreboot/+/47893/1/src/mainboard/ocp/deltalake... PS1, Line 158: SMBIOS nit: lowercase
https://review.coreboot.org/c/coreboot/+/47893/1/src/mainboard/ocp/deltalake... PS1, Line 167: { : "JCN18 - CPU MIPI60", : CONN_OTHER, : "", : CONN_NONE, : TYPE_OTHER_PORT : }, You can remove the comment above if you write the struct initializers as follows:
{ .internal_reference_designator = "JCN18 - CPU MIPI60", .internal_connector_type = CONN_OTHER, .external_reference_designator = "", .external_connector_type = CONN_NONE, .port_type = TYPE_OTHER_PORT, },