Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41159 )
Change subject: mainboard: Add HP EliteBook 2560p ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Nice.
https://review.coreboot.org/c/coreboot/+/41159/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41159/1//COMMIT_MSG@8 PS1, Line 8: How did you create the GPIO file?
https://review.coreboot.org/c/coreboot/+/41159/1/src/mainboard/hp/snb_ivb_la... File src/mainboard/hp/snb_ivb_laptops/variants/2560p/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/41159/1/src/mainboard/hp/snb_ivb_la... PS1, Line 19: others => Disabled); Are all these available?