Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35678 )
Change subject: intel/i945,i82801gx: Refactor early PCI bridge reset
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35678/1/src/northbridge/intel/i945/...
File src/northbridge/intel/i945/early_init.c:
https://review.coreboot.org/c/coreboot/+/35678/1/src/northbridge/intel/i945/...
PS1, Line 876: mdelay(200);
It was a pretty weird situation and the delay was determined experimentally (don't think that the ca […]
I can do a follow-up to drop ich7_p2p_secondary_reset() calls from both roda/ and kontron/, and this commit could go in its current form? Sure, this is ich7 code in i945, but not the only occasion of that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35678
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd5cd2afc8e41cc50abdda0fb7d063073c3acdc1
Gerrit-Change-Number: 35678
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Petr Cvek
petrcvekcz@gmail.com
Gerrit-Comment-Date: Mon, 30 Sep 2019 17:02:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Petr Cvek
petrcvekcz@gmail.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment