25 Jan
2022
25 Jan
'22
10:20 a.m.
Attention is currently required from: Nico Huber, Arthur Heymans, Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61350 )
Change subject: [RFC] commonlib/cb_err.h: add CB_NEED_REBOOT to cb_err enum ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
i'm not 100% sure what the best solution would be here, but i'd say that this is something common en […]
I just checked CB:60968 and commented on it; I don't think there's a need to have a return value to indicate a reset is needed.
--
To view, visit https://review.coreboot.org/c/coreboot/+/61350
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I25a828264171e184b07b790cfaa9b3045bbf3d95
Gerrit-Change-Number: 61350
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 25 Jan 2022 10:20:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment