Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34603 )
Change subject: src/mainboard/asus: Add h110m-e_m2 mainboard support ......................................................................
Patch Set 10:
(6 comments)
Looks like you made Jenkins very angry... all the board failed to build :P
Some small things to fix, let's hope it works this time
https://review.coreboot.org/c/coreboot/+/34603/10/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/Kconfig:
https://review.coreboot.org/c/coreboot/+/34603/10/src/mainboard/asus/h110m-e... PS10, Line 1: BOARD_ASUS-H110M_E-M2 BOARD_ASUS_H110M_E_M2
https://review.coreboot.org/c/coreboot/+/34603/10/src/mainboard/asus/h110m-e... PS10, Line 26: h110m h110m-e_m2
https://review.coreboot.org/c/coreboot/+/34603/10/src/mainboard/asus/h110m-e... PS10, Line 30: H110M H110M-E/M.2
https://review.coreboot.org/c/coreboot/+/34603/10/src/mainboard/asus/h110m-e... PS10, Line 35: : config DEVICETREE : string : default "devicetree.cb" Can be removed
https://review.coreboot.org/c/coreboot/+/34603/10/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/34603/10/src/mainboard/asus/h110m-e... PS10, Line 1: BOARD_ASUS_H110M_E-M.2 BOARD_ASUS_H110M_E_M2
https://review.coreboot.org/c/coreboot/+/34603/10/src/mainboard/asus/h110m-e... PS10, Line 2: H110M_E-M.2 H110M-E/M.2