[coreboot-gerrit] Change in coreboot[master]: nb/intel/x4x: Clean up TPM-related code

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45389 )

Change subject: nb/intel/x4x: Clean up TPM-related code
......................................................................

Patch Set 4: Code-Review+2

(2 comments)

https://review.coreboot.org/c/coreboot/+/45389/4/src/northbridge/intel/x4x/b... 
File src/northbridge/intel/x4x/bootblock.c:

https://review.coreboot.org/c/coreboot/+/45389/4/src/northbridge/intel/x4x/b... 
PS4, Line 12: 	/* Disable LaGrande Technology (LT) */
that's just plain wrong.

https://review.coreboot.org/c/coreboot/+/45389/4/src/northbridge/intel/x4x/b... 
PS4, Line 13: 	reg32 = TPM32(0);
you want to wait for the TPM_ACCESS_VALID bit set, so this code is again very wrong.