[coreboot-gerrit] [S] Change in coreboot[main]: soc/amd/phoenix/chip.c: Add PHX OpenSIL POC TP2/TP3 calls

[Martin Roth (Code Review)]

Attention is currently required from: Ana Carolina Cabral, Fred Reitberger, Jason Glenesk, Matt DeVillier, Nick Kochlowski, Paul Menzel.

Martin Roth has posted comments on this change by Nick Kochlowski. ( https://review.coreboot.org/c/coreboot/+/84915?usp=email )

Change subject: soc/amd/phoenix/chip.c: Add PHX OpenSIL POC TP2/TP3 calls
......................................................................

Patch Set 7:

(1 comment)

File src/soc/amd/phoenix/Kconfig:

https://review.coreboot.org/c/coreboot/+/84915/comment/4577a1c1_05d4c7d6?usp... :
PS7, Line 103: PLATFORM_USES_OPENSIL
> do we want this declared at the SoC level? […]

Yeah, I think that seems reasonable.  For the FSP it's in drivers/intel/[FSP1_1/FSP2_0]/Kconfig, but we don't have a driver for opensil at this point.

Maybe we should create drivers/amd/opensil and put it there?