[coreboot-gerrit] Change in coreboot[master]: mainboard: Drop `SataMode` setting from Cannon Lake devicetrees

[Felix Singer (Code Review)]

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/59889 )

Change subject: mainboard: Drop `SataMode` setting from Cannon Lake devicetrees
......................................................................

mainboard: Drop `SataMode` setting from Cannon Lake devicetrees

All Coffee Lake mainboards use the default value for the setting
`SataMode`. Thus, drop it from their devicetree.

Change-Id: Ibb329eb8b752c2220bb25f14fb6ae92dd8a308d6
Signed-off-by: Felix Singer 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/59889
Reviewed-by: Angel Pons 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/hatch/variants/akemi/variant.c
M src/mainboard/google/hatch/variants/kindred/variant.c
M src/mainboard/prodrive/hermes/devicetree.cb
M src/mainboard/purism/librem_cnl/variants/librem_14/devicetree.cb
4 files changed, 0 insertions(+), 4 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/variants/akemi/variant.c b/src/mainboard/google/hatch/variants/akemi/variant.c
index 00649c2..cc38362 100644
--- a/src/mainboard/google/hatch/variants/akemi/variant.c
+++ b/src/mainboard/google/hatch/variants/akemi/variant.c
@@ -29,7 +29,6 @@
    		return;
    	ssd_host->enabled = 0;
    	cfg->SataSalpSupport = 0;
-		cfg->SataMode = 0;
    	cfg->SataPortsEnable[1] = 0;
    	cfg->SataPortsDevSlp[1] = 0;
    	cfg->satapwroptimize = 0;
diff --git a/src/mainboard/google/hatch/variants/kindred/variant.c b/src/mainboard/google/hatch/variants/kindred/variant.c
index 3510dbb..7e63526 100644
--- a/src/mainboard/google/hatch/variants/kindred/variant.c
+++ b/src/mainboard/google/hatch/variants/kindred/variant.c
@@ -30,7 +30,6 @@
    		return;
    	ssd_host->enabled = 0;
    	cfg->SataSalpSupport = 0;
-		cfg->SataMode = 0;
    	cfg->SataPortsEnable[1] = 0;
    	cfg->SataPortsDevSlp[1] = 0;
    	cfg->satapwroptimize = 0;
diff --git a/src/mainboard/prodrive/hermes/devicetree.cb b/src/mainboard/prodrive/hermes/devicetree.cb
index e0655c5..db57382 100644
--- a/src/mainboard/prodrive/hermes/devicetree.cb
+++ b/src/mainboard/prodrive/hermes/devicetree.cb
@@ -1,7 +1,6 @@
 chip soc/intel/cannonlake
    # FSP configuration

-	register "SataMode" = "0"		# AHCI
    register "SataSalpSupport" = "0"
    register "satapwroptimize" = "1"
    register "SataPortsDevSlp[1]" = "1"	# PCH_M2_SATA_DEVSLP1
diff --git a/src/mainboard/purism/librem_cnl/variants/librem_14/devicetree.cb b/src/mainboard/purism/librem_cnl/variants/librem_14/devicetree.cb
index c8d6816..8b5c908 100644
--- a/src/mainboard/purism/librem_cnl/variants/librem_14/devicetree.cb
+++ b/src/mainboard/purism/librem_cnl/variants/librem_14/devicetree.cb
@@ -199,7 +199,6 @@
    	device pci 16.4 off end # Management Engine Interface 3
    	device pci 16.5 off end # Management Engine Interface 4
    	device pci 17.0 on	# SATA
-			register "SataMode" = "SATA_AHCI"
    		register "satapwroptimize" = "1"
    		register "SataSalpSupport" = "1"
    		# Port 2 (M.2 / inner)