15 Nov
2021
15 Nov
'21
5:09 p.m.
Attention is currently required from: Raul Rangel, Martin Roth, Julius Werner. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58982 )
Change subject: src/lib/prog_loaders: Add preload_ramstage ......................................................................
Patch Set 3:
(1 comment)
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/58982/comment/617d7bb1_5e624581 PS3, Line 1219: $(CONFIG_CBFS_PREFIX)/ramstage-align := 64 Should there be an else block here? i.e. what is ramstage-align when CONFIG_SOC_AMD_COMMON_BLOCK_LPC_SPI_DMA=n?
--
To view, visit https://review.coreboot.org/c/coreboot/+/58982
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe12de806449da25bc0033b02fcb97c3384eddc1
Gerrit-Change-Number: 58982
Gerrit-PatchSet: 3
Gerrit-Owner: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi patrick@coreboot.org
Gerrit-Reviewer: Rob Barnes robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Comment-Date: Mon, 15 Nov 2021 15:09:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment