Attention is currently required from: Eric Lai, Jakub Czapiga, Kapil Porwal, Paul Menzel, Subrata Banik, Tarun, Tarun Tuli.
Eran Mitrani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76665?usp=email )
Change subject: mb/google/rex: add support for UWB
......................................................................
Patch Set 14:
(2 comments)
File src/mainboard/google/rex/variants/rex0/fw_config.c:
https://review.coreboot.org/c/coreboot/+/76665/comment/7c39e816_a3fc7826 :
PS13, Line 164: AWB
UWB?
Done
https://review.coreboot.org/c/coreboot/+/76665/comment/b38b5cb7_81feecd8 :
PS13, Line 165: if (fw_config_probe(FW_CONFIG(FP, FP_PRESENT)))
can't we check this at line #163 itself ?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76665?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I93b3bcef84d775866df43d00c934f013e9f85c47
Gerrit-Change-Number: 76665
Gerrit-PatchSet: 14
Gerrit-Owner: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Tue, 05 Sep 2023 16:54:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment