Attention is currently required from: Eric Lai, Kapil Porwal, Shelley Chen, Subrata Banik.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79769?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: vendorcode/google/chromeos: Use unsigned int for "factory_config"
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
Patchset:
PS3:
LGTM after one issue
File src/vendorcode/google/chromeos/chromeos.h:
https://review.coreboot.org/c/coreboot/+/79769/comment/3ec83106_3690f203 :
PS3, Line 20: CHROMEOS_ERROR
Please name this something that more clearly connects it to factory config, this name is too generic (e.g. UNDEFINED_FACTORY_CONFIG).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79769?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3021b8646de4750b4c8e2a2981f42500894fa2d0
Gerrit-Change-Number: 79769
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Thu, 04 Jan 2024 16:35:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment