Asami Doi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33387 )
Change subject: mainboard/emulation/qemu-aarch64: Add new board for ARMv8 ......................................................................
Patch Set 22:
(9 comments)
I modified new file src/lib/fit_payload.c because extract() returns false even though initrd.size is already 0. I modified it to call extract() only when initrd.size is more than 0. The size of LinuxBoot's ramdisk seems to be 0 even with selecting 'Build initramfs' via 'make menuconfig'.
https://review.coreboot.org/c/coreboot/+/33387/21/Documentation/mainboard/em... File Documentation/mainboard/emulation/qemu-aarch64.md:
https://review.coreboot.org/c/coreboot/+/33387/21/Documentation/mainboard/em... PS21, Line 1: # QEMU AArch64 emulator
must be referenced from index. […]
Done
https://review.coreboot.org/c/coreboot/+/33387/21/Documentation/mainboard/em... PS21, Line 7: 2. Add a DTS to a FIT image by the util (I'm developing it now.)
How to get the DTS?
Done
https://review.coreboot.org/c/coreboot/+/33387/21/Documentation/mainboard/em... PS21, Line 12: TODO: Write the command how to build a FIT image.
already described here: https://doc.coreboot.org/lib/payloads/fit.html […]
Done
https://review.coreboot.org/c/coreboot/+/33387/21/Documentation/mainboard/em... PS21, Line 15: TODO: Make the util and write the command how to use the util
Already done automatically if you select LinuxBoot payload.
Done
https://review.coreboot.org/c/coreboot/+/33387/21/Documentation/mainboard/em... PS21, Line 17: ### 3. Make coreboot.rom with an emply payload
seems to be general workflow how to select a board, not worth of documenting it
Done
https://review.coreboot.org/c/coreboot/+/33387/21/Documentation/mainboard/em... PS21, Line 30: ### 4. Add the payload to coreboot.rom by util/cbfstool
wrong. […]
Sorry, what did you mean?
https://review.coreboot.org/c/coreboot/+/33387/21/Documentation/mainboard/em... PS21, Line 34: ```
Done
https://review.coreboot.org/c/coreboot/+/33387/21/Documentation/mainboard/em... PS21, Line 38: - The default CPU in QEMU for AArch64 is a cortex-a15 which is 32-bit ARM CPU. You need to specify 64-bit ARM CPU via `-cpu cortex-a53`.
move to top as it's important when running qemu for this board
I moved the "Running coreboot in QEMU" column to the top of this page.
https://review.coreboot.org/c/coreboot/+/33387/21/src/mainboard/emulation/qe... File src/mainboard/emulation/qemu-aarch64/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/33387/21/src/mainboard/emulation/qe... PS21, Line 26: BOOTBLOCK(0x60010000, 64K)
that assumes 512+32MiB of DRAM specified with -m. That needs to be documented.
OK. I added "You need to specify the size of memory more than 544 MiB because 512 MiB is reserved for a FIT image." to the documentation.