Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37402 )
Change subject: soc/amd/common/blocks: introduce two new BIOSRAM based common blocks ......................................................................
Patch Set 1:
(2 comments)
You can combine new ramtop.c and uma.c and make it acpimmio/biosram.c.
https://review.coreboot.org/c/coreboot/+/37402/1/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/biosram_layout.h:
https://review.coreboot.org/c/coreboot/+/37402/1/src/soc/amd/common/block/in... PS1, Line 21: Bring prototypes from uma.h here and remove that file. You can remove _layout from filename too.
https://review.coreboot.org/c/coreboot/+/37402/1/src/soc/amd/common/block/ra... File src/soc/amd/common/block/ramtop/Kconfig:
https://review.coreboot.org/c/coreboot/+/37402/1/src/soc/amd/common/block/ra... PS1, Line 1: config SOC_AMD_COMMON_BLOCK_RAMTOP I am pretty sure we can do with just SOC_AMD_COMMON_BLOCK_BIOSRAM.
We expand/split this if we ever find a reason to do so.