Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37781 )
Change subject: soc/intel/tigerlake: Update ACPI files ......................................................................
Patch Set 11:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37781/11/src/soc/intel/tigerlake/ac... File src/soc/intel/tigerlake/acpi/pch_clock_ctl.asl:
https://review.coreboot.org/c/coreboot/+/37781/11/src/soc/intel/tigerlake/ac... PS11, Line 22: 0xFD000000
That should be a define or read from pci config space
Ack
https://review.coreboot.org/c/coreboot/+/37781/11/src/soc/intel/tigerlake/ac... PS11, Line 23: 0xAD
That should be a define, too
Ack
https://review.coreboot.org/c/coreboot/+/37781/11/src/soc/intel/tigerlake/ac... PS11, Line 134: IMGCLKOUT_4
Why is 5 missing
Ack