Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38546 )
Change subject: cpu/x86: Make MP init timeout configurable ......................................................................
Patch Set 10:
(2 comments)
Thanks for the review. I have changes ready but not able to send right now. The current tip is broken for my compiler, the change identified is not committed yet.
https://review.coreboot.org/c/coreboot/+/38546/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38546/9//COMMIT_MSG@15 PS9, Line 15: needs to be heuristic
In the Tioga Pass case, is it that MP init takes longer than one second, or does some core get stall […]
Makes sense that failure handling in this case should be improved. There could be real failures (such as due to burnt out core or due to the inter-socket physical link getting damaged), so timeout as the last defense is necessary. For TiogaPass server I have (which has 72 cpus; 80 cpus TiogaPass is most common), in most cases 1s is good enough, it does fail sometimes; also if a single debug print is added, it fails almost all the time.
https://review.coreboot.org/c/coreboot/+/38546/10/src/cpu/x86/mp_init.c File src/cpu/x86/mp_init.c:
https://review.coreboot.org/c/coreboot/+/38546/10/src/cpu/x86/mp_init.c@152 PS10, Line 152: static int max(int x, int y)
#include <stddef.h> […]
Thank you!