[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/atlas: Not not override icc_max

[Caveh Jalali (Code Review)]

Hello caveh jalali,

I'd like you to do a code review. Please visit

https://review.coreboot.org/27791

to review the following change.

Change subject: mb/google/poppy/variants/atlas: Not not override icc_max
......................................................................

mb/google/poppy/variants/atlas: Not not override icc_max

Skylake SoC code now sets the icc_max based on the CPU SKU, so we
should not hard-code it in the device tree.

BUG=b:110890675
BRANCH=None
TEST=boots on atlas

Change-Id: I7eb3499b7bea9ab2c49e1f299e2dbb688c8d1c33
Signed-off-by: Caveh Jalali 
---
M src/mainboard/google/poppy/variants/atlas/devicetree.cb
1 file changed, 5 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/27791/1

diff --git a/src/mainboard/google/poppy/variants/atlas/devicetree.cb b/src/mainboard/google/poppy/variants/atlas/devicetree.cb
index f6610df..98a49bc 100644
--- a/src/mainboard/google/poppy/variants/atlas/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/atlas/devicetree.cb
@@ -86,7 +86,7 @@
    #| Psi4Enable     | 1     | 1     | 1     | 1     |
    #| ImonSlope      | 0     | 0     | 0     | 0     |
    #| ImonOffset     | 0     | 0     | 0     | 0     |
-	#| IccMax         | 4A    | 24A   | 24A   | 24A   |
+	#| IccMax         | 0     | 0     | 0     | 0     |
    #| VrVoltageLimit | 1.52V | 1.52V | 1.52V | 1.52V |
    #| AcLoadline     | 14.9  | 5     | 5.7   | 4.57  |
    #| DcLoadline     | 14.2  | 4.86  | 4.2   | 4.3   |
@@ -100,7 +100,7 @@
    	.psi4enable = 1,
    	.imon_slope = 0x0,
    	.imon_offset = 0x0,
-		.icc_max = VR_CFG_AMP(4),
+		.icc_max = 0,
    	.voltage_limit = 1520,
    	.ac_loadline = 1490,
    	.dc_loadline = 1420,
@@ -115,7 +115,7 @@
    	.psi4enable = 1,
    	.imon_slope = 0x0,
    	.imon_offset = 0x0,
-		.icc_max = VR_CFG_AMP(24),
+		.icc_max = 0,
    	.voltage_limit = 1520,
    	.ac_loadline = 500,
    	.dc_loadline = 486,
@@ -130,7 +130,7 @@
    	.psi4enable = 1,
    	.imon_slope = 0x0,
    	.imon_offset = 0x0,
-		.icc_max = VR_CFG_AMP(24),
+		.icc_max = 0,
    	.voltage_limit = 1520,
    	.ac_loadline = 570,
    	.dc_loadline = 420,
@@ -145,7 +145,7 @@
    	.psi4enable = 1,
    	.imon_slope = 0x0,
    	.imon_offset = 0x0,
-		.icc_max = VR_CFG_AMP(24),
+		.icc_max = 0,
    	.voltage_limit = 1520,
    	.ac_loadline = 457,
    	.dc_loadline = 430,