Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46268 )
Change subject: soc/intel/common/block/acpi: Factor out common buttons.asl ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46268/1/src/mainboard/intel/icelake... File src/mainboard/intel/icelake_rvp/acpi/mainboard.asl:
https://review.coreboot.org/c/coreboot/+/46268/1/src/mainboard/intel/icelake... PS1, Line 6: Device (PWRB) Why does ChromeOS need this ACPI device? See CB:38134 for reasons to not have this in ACPI tables.