Erin Lo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31516 )
Change subject: google/kukui: boot up sspm
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31516/1/src/mainboard/google/kukui/mainboard...
File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/#/c/31516/1/src/mainboard/google/kukui/mainboard...
PS1, Line 44: unsigned char buf[BUF_SIZE];
Yeah, that's definitely the right thing to do, don't copy 64KB around more than necessary.
SSPM_SRAM_BASE is accessed through APB box. It can't support byte access only supports word access. Does it touch any limitation in cbfs_boot_load_file()? I found "lzma: Decoding error = 1" when directly load the file into SSPM_SRAM_BASE.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31516
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ae6034454326f5115cd3948819adc448b67fb1c
Gerrit-Change-Number: 31516
Gerrit-PatchSet: 2
Gerrit-Owner: Erin Lo
erin.lo@mediatek.com
Gerrit-Reviewer: Chun-ta Lin
itspeter@google.com
Gerrit-Reviewer: Erin Lo
erin.lo@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Erin Lo
erin.lo@mediatek.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Comment-Date: Wed, 27 Feb 2019 02:25:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Erin Lo
erin.lo@mediatek.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: You-Cheng Syu
youcheng@google.com
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment