[coreboot-gerrit] Change in coreboot[master]: drivers/sn65dsi86: Switch EDID reading to use "indirect mode"

[Douglas Anderson (Code Review)]

Attention is currently required from: Vinod Polimera, Julius Werner, Xuxin Xiong.
Douglas Anderson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52959 )

Change subject: drivers/sn65dsi86: Switch EDID reading to use "indirect mode"
......................................................................

Patch Set 2: Code-Review-1

(2 comments)

Patchset:

PS2: 
I ran out of time to review this today. :( I'll prioritize tomorrow. It sounds as if testing showed that it had problems though. I _might_ have found the problem looking at the code?

File src/drivers/ti/sn65dsi86bridge/sn65dsi86bridge.c:

https://review.coreboot.org/c/coreboot/+/52959/comment/ce1ab89d_81b723eb 
PS2, Line 201: AUX_CMD_SEND
From looking at the kernel code (and the samples in the ti manual IIRC), I believe you can't set this yet. You've got to do the writes first.

In the kernel code it actually writes SN_AUX_CMD_REG twice. Once with just the command and then a second time with the command ORed with "SEND". IIRC that's what the manual said, too.