Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43332 )
Change subject: soc/amd/picasso: Add support for DRIVERS_USB_PCI_XHCI ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43332/1/src/soc/amd/picasso/xhci.c File src/soc/amd/picasso/xhci.c:
https://review.coreboot.org/c/coreboot/+/43332/1/src/soc/amd/picasso/xhci.c@... PS1, Line 15: mainboard_get_gpe_table
How about we just hard code it here in the soc code and don't let the mainboard customize it? […]
In my opinion, it is totally fine to keep(hard code) this within the soc/ rather than having mainboard provide it. The SoC should be able to make a decision about all the different controllers i.e. what GEVENT# to assign. Since it also controls exporting this via ACPI, I think it would work just fine.