build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42859 )
Change subject: amdfwtool: Take a config file instead of command line parameters ......................................................................
Patch Set 61:
(6 comments)
https://review.coreboot.org/c/coreboot/+/42859/61/util/amdfwtool/amdfwtool.c File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/42859/61/util/amdfwtool/amdfwtool.c... PS61, Line 1468: fprintf(stderr, "Config file is parsed error. Please check the format: %s\n", line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/61/util/amdfwtool/data_parse.... File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/42859/61/util/amdfwtool/data_parse.... PS61, Line 228: else return 1; trailing statements should be on next line
https://review.coreboot.org/c/coreboot/+/42859/61/util/amdfwtool/data_parse.... PS61, Line 349: 1: The config file can be parsed correctly. code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/42859/61/util/amdfwtool/data_parse.... PS61, Line 391: if (find_register_fw_filename_psp_dir(&(oneline[match[1].rm_so]), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/61/util/amdfwtool/data_parse.... PS61, Line 393: if (find_register_fw_filename_bios_dir(&(oneline[match[1].rm_so]), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42859/61/util/amdfwtool/data_parse.... PS61, Line 395: return 0; /* This line is not valid. Stop parsing. */ line over 96 characters