Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37478 )
Change subject: libpayload: Cache physical cbmem console address ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37478/1/payloads/libpayload/drivers... File payloads/libpayload/drivers/cbmem_console.c:
https://review.coreboot.org/c/coreboot/+/37478/1/payloads/libpayload/drivers... PS1, Line 64: cbmem_console_p
Sorry, I didn't mean C pointers. Just addresses, they are already uints.
Okay, but then when it's an integer type doesn't that provide enough of a hint that it's a physical address?
But I just fail to see the point of `struct sysinfo` if we don't import the information. If it's merely a collection of pointers to CB stuff without any abstraction, we'll
depend on the CB structures everywhere.
I don't see how that would be a problem? I'm not sure what the point would be in copying things around that you already have elsewhere.
We could as well just drop `sysinfo` and discover things on demand.
Well, in my understanding lib_sysinfo is just a directory of all the stuff discovered from the coreboot table. So that you don't have to parse the table over and over again for every lookup. I think the more detailed interpretation of what that data means can belong in the individual drivers dealing with it.