Attention is currently required from: Furquan Shaikh. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48446 )
Change subject: mb/google/brya: Add memory DQ map ......................................................................
Patch Set 7:
(5 comments)
File src/mainboard/google/brya/romstage.c:
https://review.coreboot.org/c/coreboot/+/48446/comment/f0580426_a954f41b PS6, Line 12: ;
()
Done
File src/mainboard/google/brya/variants/baseboard/include/baseboard/gpio.h:
https://review.coreboot.org/c/coreboot/+/48446/comment/85332b5c_a17165b0 PS5, Line 14: /* Memory configuration board straps */
Honestly, I think we don't need these GPIO_* macros here. […]
Done
https://review.coreboot.org/c/coreboot/+/48446/comment/27c51955_98331113 PS5, Line 20: GPIO_MEM_CH_SEL
Same here. This is used in just one place. Let's just drop it from here for now.
Done
File src/mainboard/google/brya/variants/baseboard/memory.c:
https://review.coreboot.org/c/coreboot/+/48446/comment/c43b3269_5e44fc36 PS6, Line 68: /* Memory configuration board straps */ : #define GPIO_MEM_CONFIG_0 GPP_E11 : #define GPIO_MEM_CONFIG_1 GPP_E2 : #define GPIO_MEM_CONFIG_2 GPP_E1 : #define GPIO_MEM_CONFIG_3 GPP_E12
I think we can just drop the macros completely.
Done
https://review.coreboot.org/c/coreboot/+/48446/comment/adde91bb_04131780 PS6, Line 86: #define GPIO_MEM_CH_SEL GPP_E13
Not really required. You can use GPP_E13 directly.
Done