Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37177 )
Change subject: sb/amd/{agesa,pi}/hudson: enable support for AMD common ACPIMMIO blocks ......................................................................
Patch Set 1:
(4 comments)
We want to coordinate this with AMD/SilverBack/Google such that soc/amd/common and SOC_AMD_COMMON are usable without copy-pasting headers under southbridge/hudson .
https://review.coreboot.org/c/coreboot/+/37177/1/src/southbridge/amd/agesa/h... File src/southbridge/amd/agesa/hudson/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/37177/1/src/southbridge/amd/agesa/h... PS1, Line 4: CPPFLAGS_common += -I$(src)/southbridge/amd/agesa/hudson/include Lets not introduce include/ there.
https://review.coreboot.org/c/coreboot/+/37177/1/src/southbridge/amd/agesa/h... File src/southbridge/amd/agesa/hudson/include/soc/iomap.h:
https://review.coreboot.org/c/coreboot/+/37177/1/src/southbridge/amd/agesa/h... PS1, Line 5: * Copyright 2017 Google Inc. I guess this is copy from somewhere?
https://review.coreboot.org/c/coreboot/+/37177/1/src/southbridge/amd/agesa/h... PS1, Line 25: #include <amdblocks/acpimmio_map.h> Why?
https://review.coreboot.org/c/coreboot/+/37177/1/src/southbridge/amd/pi/huds... File src/southbridge/amd/pi/hudson/include/soc/iomap.h:
https://review.coreboot.org/c/coreboot/+/37177/1/src/southbridge/amd/pi/huds... PS1, Line 25: #include <amdblocks/acpimmio_map.h> Why ?