Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34588 )
Change subject: util/inteltool: Add Intel HD 4400 (Haswell IGD)
......................................................................
Patch Set 8: Code-Review+2
(1 comment)
Forgot to send, was already fixed
https://review.coreboot.org/c/coreboot/+/34588/7/util/inteltool/inteltool.h
File util/inteltool/inteltool.h:
https://review.coreboot.org/c/coreboot/+/34588/7/util/inteltool/inteltool.h@...
PS7, Line 317: #define PCI_DEVICE_ID_INTEL_HD_4400 0x041e
And the IDs seem to use uppercase letters, so please be consistent about it
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34588
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6d6b2eaa7cc5aa3912592ed3fcb73751b224eede
Gerrit-Change-Number: 34588
Gerrit-PatchSet: 8
Gerrit-Owner: Christoph Pomaska
github@aufmachen.jetzt
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Christoph Pomaska
github@aufmachen.jetzt
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: cpresser
Gerrit-Comment-Date: Sun, 15 Sep 2019 16:05:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment