Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43756 )
Change subject: cast all void *cbmem_top_chipset() function to uintptr_t ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/43756/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43756/1//COMMIT_MSG@9 PS1, Line 9: Cast all cbmem_top_chipset to uintptr_t Why? What for? It would be nice to explain that in the commit message.
https://review.coreboot.org/c/coreboot/+/43756/1/src/acpi/acpi.c File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/43756/1/src/acpi/acpi.c@510 PS1, Line 510: int acpi_create_srat_lx2apic(acpi_srat_lx2apic_t *lx2apic, u8 node, u8 x2apic) This doesn't belong to this patch
https://review.coreboot.org/c/coreboot/+/43756/1/src/include/acpi/acpi.h File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/43756/1/src/include/acpi/acpi.h@238 PS1, Line 238: /* SRAT: x2APIC Affinity Structure */ This doesn't belong to this patch
https://review.coreboot.org/c/coreboot/+/43756/1/src/include/acpi/acpi.h@952 PS1, Line 952: int acpi_create_srat_lx2apic(acpi_srat_lx2apic_t *lx2apic, u8 node, u8 x2apic); This doesn't belong to this patch