[coreboot-gerrit] Change in coreboot[master]: drivers/genesyslogic/gl9763e: Add driver for Genesys Logic GL9763E

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43751 )

Change subject: drivers/genesyslogic/gl9763e: Add driver for Genesys Logic GL9763E
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43751/6/src/drivers/genesyslogic/gl... 
File src/drivers/genesyslogic/gl9763e/gl9763e.c:

https://review.coreboot.org/c/coreboot/+/43751/6/src/drivers/genesyslogic/gl... 
PS6, Line 23: 	pci_update_config32(dev, VHS, ~VHS_REV_MASK, VHS_REV_R);
> ASPM control is on Line 20. […]

Maybe add this information as comments above each line?

/* Set VHS (Vendor Header Space) to be writable */
 pci_update_config32(dev, VHS, ~VHS_REV_MASK, VHS_REV_W);

/* Set single AXI request */
 pci_or_config32(dev, SCR, SCR_AXI_REQ);

/* Disable L0s support */
 pci_and_config32(dev, CFG_REG_2, ~CFG_REG_2_L0S);

/* Set SSC to 30000 ppm */
 pci_update_config32(dev, PLL_CTL_2, ~PLL_CTL_2_MAX_SSC_MASK, MAX_SSC_30000PPM);

/* Enable SSC */
 pci_or_config32(dev, PLL_CTL, PLL_CTL_SSC);

/* Set VHS to read-only */
 pci_update_config32(dev, VHS, ~VHS_REV_MASK, VHS_REV_R);