Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40351 )
Change subject: mb/dell/optiplex_9010: Add Dell OptiPlex 9010 SFF support ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40351/9/src/mainboard/dell/optiplex... File src/mainboard/dell/optiplex_9010/romstage.c:
https://review.coreboot.org/c/coreboot/+/40351/9/src/mainboard/dell/optiplex... PS9, Line 17: uint16_t ec_fw_version; : : sch5545_emi_init(0x2e); : if (sch5545_emi_get_int_mask_high()) : printk(BIOS_SPEW, "EC interrupt mask MSB is not 0\n"); : : sch5545_emi_disable_interrupts(); : sch5545_ec_early_init(); : sch5545_ec_hwm_early_init(); : : if (!s3resume) { : ec_fw_version = sch5545_get_ec_fw_version(); : printk(BIOS_DEBUG, "SCH5545 EC firmware version %04x\n", ec_fw_version); : sch5545_update_ec_firmware(ec_fw_version); : } : printk(BIOS_DEBUG, "EC early init complete.\n");
IMO bootblock should do only basic initialization of CAR and Super I/O. […]
Sure thing. Added a comment at the beginning of the function.