Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37652 )
Change subject: soc/intel/common: Add Elkhartlake Device IDs ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37652/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37652/1//COMMIT_MSG@7 PS1, Line 7: Elkhartlake
Elkhart Lake?
Using the same format as previous intel patches, jasperlake, tigerlake, cannonlake etc.
https://review.coreboot.org/c/coreboot/+/37652/1/src/soc/intel/common/block/... File src/soc/intel/common/block/systemagent/systemagent.c:
https://review.coreboot.org/c/coreboot/+/37652/1/src/soc/intel/common/block/... PS1, Line 371: PCI_DEVICE_ID_INTEL_JSL_EHL,
Unrelated?
updated in commit message, this MCH id is shared between JSL and EHL SKUs.
https://review.coreboot.org/c/coreboot/+/37652/1/src/soc/intel/tigerlake/boo... File src/soc/intel/tigerlake/bootblock/report_platform.c:
https://review.coreboot.org/c/coreboot/+/37652/1/src/soc/intel/tigerlake/boo... PS1, Line 52: { PCI_DEVICE_ID_INTEL_JSL_EHL, "Jasperlake Elkhartlake" },
Please elaborate in the commit message.
Done